Remove scary disconenct warnings on PeerManager new connection fns #1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1626 +/- ##
=======================================
Coverage 90.80% 90.81%
=======================================
Files 80 80
Lines 44654 44724 +70
Branches 44654 44724 +70
=======================================
+ Hits 40550 40618 +68
- Misses 4104 4106 +2
Continue to review full report at Codecov.
|
tnull
reviewed
Jul 22, 2022
dunxen
previously approved these changes
Jul 24, 2022
valentinewallace
previously approved these changes
Jul 25, 2022
|
Feel free to squash! |
In 4703d4e we changed PeerManager::socket_disconnected to no longer require that sockets which the PeerManager decided to disconnect not be disconnected. However, we forgot to remove the scary warnings on the `new_{inbound,outbound}_connection` functions which warned of the old behavior. We do so here.
|
Squashed without change. |
TheBlueMatt
dismissed stale reviews from valentinewallace and dunxen
via
19b5a48
TheBlueMatt
force-pushed
the
2022-07-fix-pm-docs
branch
from
561b4bc to
19b5a48
Compare
valentinewallace
approved these changes
Jul 25, 2022
tnull
approved these changes
Jul 25, 2022
|
Ah, grr, totally forgot to point out the spelling mistake that persisted in the commit message after squashing.. |
|
Oops, sorry lol. Oh well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4703d4e we changed
PeerManager::socket_disconnected to no longer require that sockets
which the PeerManager decided to disconnect not be disconnected.
However, we forgot to remove the scary warnings on the
new_{inbound,outbound}_connectionfunctions which warned of theold behavior.
We do so here.